Fuzzy search of docs #1007
Merged
Fuzzy search of docs #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Commit ba72bc3 Deployed on https://web-php-pr-1007.preview.thephp.foundation |
|
Some inline styles still need to go into CSS. Seeking feedback before marking PR as ready. |
saundefined
approved these changes
Aug 2, 2024
|
I still haven't got the fuzzy search parameters right. I think I got better matches with the original commit. I've tweaked them several times but it's hard to find a balance. Other fuzzy match libraries aren't pre-packaged as a typeahead backend, and are generally more strict. I'm aiming for enough fuzziness that people who are new to the language will have a decent chance of finding a function without knowing its name. |
Allow partial terms and multiple search tokens instead of rigid 'begins-with' substring matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow partial terms and multiple search tokens instead of rigid 'begins-with' substring matching.
This isn't perfect and could probably do with some tuning of the FuzzySearch parameters, but it's better than the current, very unforgiving, method.
It also adds the
.phpsuffix to selected autocomplete results (to match the canonical tags), stops the results list from becoming inaccessible when taller than the viewport, and drops a couple of unused variables.